Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

V7.0.1 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohammadrezaeicode merged 8 commits into main from V7.0.0
Mar 13, 2025
Merged

V7.0.1 #6

mohammadrezaeicode merged 8 commits into main from V7.0.0
Mar 13, 2025

Conversation

@mohammadrezaeicode
Copy link
Owner

@mohammadrezaeicode mohammadrezaeicode commented Mar 12, 2025

Pull Request

Type of Change

Please select the type(s) of changes made in your pull request:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes to documentation)
  • Other (please describe):

@mohammadrezaeicode mohammadrezaeicode added the bug Something isn't working label Mar 12, 2025
Copy link
Contributor

Hi @mohammadrezaeicode, curious if this version is going to be published automatically, or does it need a manual intervention?

xergiodf reacted with hooray emoji

@mohammadrezaeicode mohammadrezaeicode merged commit 703d4c3 into main Mar 13, 2025
6 checks passed
Copy link
Owner Author

Hi @mohammadrezaeicode, curious if this version is going to be published automatically, or does it need a manual intervention?

Hi @xergiodf ,
After version 7.0.0, the action is now triggered manually. Your change has been published and is included in version 7.0.1.

m.r and others added 5 commits March 13, 2025 01:28
* V7.0.0 (#4)
* Create manually_test.yml
* feature: init V7.0.0
* add comment to interface and main func & update readme
---------
Co-authored-by: m.r <mr@example.com>
* fix: changed custom dollar_rounded format key and numFmtId to 188
## Description
`dollar_2` and `dollar_rounded` defined 2 different `formatCode`, although they have the same `key` and `numFmtId` set to 183.
This cause an issue when using both formats in a sheet, where only 1 is applied because the `183` id is used for reference in the spreadsheet context.
The fix is to set `dollar_rounded` id to something else: 188 (last used key value was 187).
Also, ordered the object by key value for better readability.
---------
Co-authored-by: mohammadrezaeicode <131792366+mohammadrezaeicode@users.noreply.github.com>
Co-authored-by: m.r <mr@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /