-
Couldn't load subscription status.
- Fork 1
fix: changed custom dollar_rounded format key and numFmtId to 188 #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: changed custom dollar_rounded format key and numFmtId to 188 #5
Conversation
* Create manually_test.yml * feature: init V7.0.0 * add comment to interface and main func & update readme --------- Co-authored-by: m.r <mr@example.com>
## Description `dollar_2` and `dollar_rounded` defined 2 different `formatCode`, although they have the same `key` and `numFmtId` set to 183. This cause an issue when using both formats in a sheet, where only 1 is applied because the `183` id is used for reference in the spreadsheet context. The fix is to set `dollar_rounded` id to something else: 188 (last used key value was 187). Also, ordered the object by key value for better readability.
@mohammadrezaeicode can you please review? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can rollback the ordering if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual change
Hi,
Thank you for participating again. I’ve merged the changes. Please note that we have a formatMap option available, which can override existing formats and add new formats to the current ones.
ac9d7f5
into
mohammadrezaeicode:V7.0.0
Hi,
Thank you for participating again. I’ve merged the changes. Please note that we have a formatMap option available, which can override existing formats and add new formats to the current ones.
Oh! thanks for the advice. I'm still getting familiar with the library features. I'll keep contributing as possible 🙏
Pull Request
Description
dollar_2anddollar_roundeddefined 2 differentformatCode, although they have the samekeyandnumFmtIdset to 183.This causes an issue when using both formats in a sheet, where only 1 is applied because the
183id is used for reference in the spreadsheet context.The fix is to set
dollar_roundedid to something else: 188 (last used key value was 187).Also, ordered the object by key value for better readability.
Type of Change
Testing
Steps:
maindollar_roundedimage