-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fixes Persistent not not sending #3324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Taaku18
merged 2 commits into
modmail-dev:development
from
martinbndr:fix-persistent-note
Oct 27, 2024
Merged
Fixes Persistent not not sending #3324
Taaku18
merged 2 commits into
modmail-dev:development
from
martinbndr:fix-persistent-note
Oct 27, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes persistent note not sending on thread creation.
@Taaku18 Please take a look at pr ́s like this that fixes relatively small things that are somehow important for small features. These could be released regardless of having a big bot update or not.
Currently if users having persistent notes they won ́t get sent after they created a new thread
Taaku18
Taaku18
approved these changes
Oct 27, 2024
Taaku18
Taaku18
approved these changes
Oct 27, 2024
Taaku18
added a commit
that referenced
this pull request
Oct 27, 2024
So can this be merged to master? @Taaku18 Its quite needed for peristent notes...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes persistent notes not sending on thread creation.
This error raised:
Maybe not ideal solution but adding the
cachearg to the store_user() funtion at line 253 fixes it.