-
-
Notifications
You must be signed in to change notification settings - Fork 320
fix(dev-server-esbuild): properly parse tsconfig files from the provided path using get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config
#2972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anthony-y-zhu14
wants to merge
3
commits into
modernweb-dev:master
from
anthony-y-zhu14:patch/tsconfig-auto-resolve
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: auto resolve tsconfig as tsconfig.json if ts is set to true
🦋 Changeset detectedLatest commit: 6b01b33 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@anthony-y-zhu14
anthony-y-zhu14
changed the title
(削除) properly parse tsconfig files from the provided path using
(追記) fix: properly parse tsconfig files from the provided path using Jul 26, 2025
get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config (削除ここまで)get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config (追記ここまで)
@anthony-y-zhu14
anthony-y-zhu14
changed the title
(削除) fix: properly parse tsconfig files from the provided path using
(追記) fix(dev-server-esbuild): properly parse tsconfig files from the provided path using Jul 26, 2025
get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config (削除ここまで)get-tsconfig, default tsconfig path to tsconfig.json if ts or tsx is true in config (追記ここまで)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
extendsintsconfig.jsondev-server-esbuild#20 to the dev-server-esbuild package in web monorepo (not clear why theres two copy of the same package)