impl FromLua for serde_json::Value #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

lightsing wants to merge 1 commit into mlua-rs:main

from vlegend-game:feat/serde_json

Open

impl FromLua for serde_json::Value #302

lightsing wants to merge 1 commit into mlua-rs:main from vlegend-game:feat/serde_json

Conversation

@lightsing

Copy link

Contributor

@lightsing lightsing commented Aug 2, 2023

This pull request introduces the implementation of the FromLua trait for serde_json::Value. This will allow smooth conversion from Lua values to serde_json values and get rid of the 'lua lifetime, providing better integration and flexibility.

Details:

Added a new feature flag for json:
A new feature flag named json has been added, dependent on both the serialize feature and the serde_json crate. This allows the conditional compilation of the new implementation, ensuring backward compatibility.
Updated Cargo.toml:
- Added serde_json as an optional dependency, with version "1.0".
Updated src/value.rs:
- Added an implementation block for FromLua trait for serde_json::Value.
- Inside the from_lua method, a value of Lua type is converted to a serde_json::Value, handling any potential conversion errors and wrapping them into the Error::FromLuaConversionError.