Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Up to upstream:master #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitsuruog merged 158 commits into mitsuruog:upstream from ryanmcdermott:master
Jan 14, 2019
Merged

Up to upstream:master #4

mitsuruog merged 158 commits into mitsuruog:upstream from ryanmcdermott:master
Jan 14, 2019

Conversation

@mitsuruog
Copy link
Owner

@mitsuruog mitsuruog commented Jan 14, 2019

No description provided.

rouzbeh84 and others added 30 commits April 20, 2017 10:14
updating function name per #200 thanks to @marzelin to clean up some issues
updating L278 to `isActiveClient`
...you will find that those *case*... -> ..you will find that those *cases*...
Update README.md to include explanatory function names per #200 
* translate kata pengantar / introduction
* translate variabel
* typo
* function 1/2
* 1/2 replace
* translate ### 😂
* translate Function section in Bahasa Indonesia is done
* 1/2 SOLID translation to Bahasa Indonesia
* SOLID translation to Bahasa Indonesia is Done
* translating Error Handling to bahasa indonesia is done
* well done, translated to Bahasa Indonesia
* review 1, check typo
* review 2
* just link
Capital letters in const, remove default data in class Car
Capital letters in const, remove default data in class Car
The proposed "good" way of coding was actually changing a property's name in the developers object.
While one can argue that in this case they could be the same, the point of the example was to show that you can still remove duplicated code that require *different* things.
Remove space before colon in object.
'data' is never reassigned. Use 'const' instead.
...turing
Replace map method with object destructuring
There's -> There are
iheanyi and others added 28 commits October 13, 2018 13:53
Hey there. As a Software Engineer who happens to be Nigerian, I think there are better ways of explaining a side effect than perpetuating stereotypes about a specific group of people. So I just made a small fix to make it more appropriate.
Use `console.error` at least as `console.log` essentially turns a thrown error into a muted console log.
In the "good" `Object.assign` example, the initial new object is redundant as the defaults are also specified in a new object.
This is a bit pedantic, and doesn't change the semantics of the example, just removes an unnecessary object creation.
The original phrase "As stated in the Gang of Four..." is semantically incorrect.
- The "Gang of Four" is a group of authors: Erich Gamma, Richard Helm, Ralph Johnson and John Vlissides.
- They wrote a famous book: Design Patterns.
- Here, Ryan McDermott is referring to the software-design principle "you should prefer composition over inheritance."
- This principle was stated in the book, Design Patterns.
- It was not stated in the Gang of Four -- the authors themselves.
per preceding rule "ES6 constants when variable values do not change"
In the section "Functions should do one thing" this change uses
the Array.filter method to get the active clients, then emailing
those with the forEach loop.
The save method isn't returning this, so the car variable
is equal to undefined instead of a Car object.
BTW, Thanks alot for this guide.
...witch to "ES<year>/ES<edition>" when mentioning ECMAScript versions.
Something looked off about this so I did a quick check in node.
You must have been distracted at the time of writing :)
We need a better explanation for when to prefer `const` over var/let,
as this has confused many readers.
@mitsuruog mitsuruog merged commit b9000e1 into mitsuruog:upstream Jan 14, 2019
mitsuruog added a commit that referenced this pull request Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

AltStyle によって変換されたページ (->オリジナル) /