Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added security_and_analysis block support #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iluwaa wants to merge 1 commit into mineiros-io:main
base: main
Choose a base branch
Loading
from iluwaa:added_security_and_analysis_support

Conversation

@iluwaa
Copy link

@iluwaa iluwaa commented Nov 28, 2022

No description provided.

@iluwaa iluwaa force-pushed the added_security_and_analysis_support branch from b85c12f to 346b4e0 Compare November 28, 2022 14:55
@iluwaa iluwaa force-pushed the added_security_and_analysis_support branch from 346b4e0 to 5b0ddf5 Compare November 28, 2022 14:58
@iluwaa iluwaa marked this pull request as ready for review November 28, 2022 14:58
@iluwaa iluwaa requested review from a team and mariux as code owners November 28, 2022 14:58
Copy link

@mineiros-ci @mineiros-team any update on when this PR can be merged. It'll really be useful to have security configuration

cleydsonvts and magzim21 reacted with thumbs up emoji

Copy link

gaima8 commented Jun 15, 2023

As I understand it the container used to run checks on PR (make test/docker/pre-commit) has terraform v1.1.7.

This PR uses optional attributes with a default value. terraform didn't add support for optional attributes with a default value until v1.3 though.
https://developer.hashicorp.com/terraform/language/v1.1.x/expressions/type-constraints#experimental-optional-object-type-attributes
https://developer.hashicorp.com/terraform/language/expressions/type-constraints#optional-object-type-attributes

Among other things https://github.com/mineiros-io/build-tools/blob/422e2711d58426624e1b3db54eff8d1620682a2c/Makefile#L8 would need to change to support this.

automaticgiant reacted with confused emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariux mariux Awaiting requested review from mariux mariux is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /