-
Couldn't load subscription status.
- Fork 232
Having clauses missing from the generated CacheKey #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@charlie-waddell Thanks so much for taking the time to write up a PR. I will try to get this merged soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this! Could you write some tests to cover the code you added? Thanks!
Restingo
commented
Jul 4, 2022
@charlie-waddell did you find some time to add tests? Thank you.
If anyone would like to pick this up and add tests, that would be great. I'm happy to merge once those are in.
Signed-off-by: Mike Bronner <mike@genealabs.com>
Uh oh!
There was an error while loading. Please reload this page.
The issue:
When a query has having clauses, the changes are not detected because these appear to be missed from the generation of the cache key. Example: