-
Notifications
You must be signed in to change notification settings - Fork 232
Add PHP Matrix and caching #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its common to do a matrix for supported PHP versions and to cache composer dependencies for faster runs.
Thanks for the updates :). Blarg, so it looks like actions don't apply env vars to PRs either ... I'll research that more this weekend.
@mikebronner Yeah you will probs have to go down a similar approach
- name: Remove Nova on a Pull Request if: github.event_name == 'pull_request' run: composer remove laravel/nova --no-update --no-interaction # Install dependencies & other steps... - name: Execute Integration and Feature tests via PHPUnit run: vendor/bin/phpunit --configuration phpunit.xml.dist --testsuite Integration,Feature - name: Execute Nova tests via PHPUnit if: github.event_name != 'pull_request' run: vendor/bin/phpunit --configuration phpunit.xml.dist --testsuite Nova
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Its common to do a matrix for supported PHP versions and to cache composer dependencies for faster runs.
image
Note: Installing nova will fail on PRs as it tries to install nova when access to secrets is blocked. The same problem we had with travis.