- 
  Notifications
 You must be signed in to change notification settings 
- Fork 232
Fix Typo of Caching Trait's checkCooldownAndFlushAfterPersiting method #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
 
  Merged
 
 
 Conversation
 
 
 This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
 Learn more about bidirectional Unicode characters
 
 
 
 
 
 
 @jacobzlogar
jacobzlogar
 changed the title
(削除) Fix Typo of Caching Trait's 
(追記) Fix Typo of Caching Trait's checkCooldownAndFlushAfterPersiting method (追記ここまで)
 Nov 9, 2018 
 
 checkCooldownAndFlushAfterPersiting method (削除ここまで)@jacobzlogar Thanks for finding this typo.
@mikebronner i didn’t look into why tests might be failing, did you ever get a chance to take a look?
@jacobzlogar yea, it was Travis ... no worries, I verified everything
 
 Sign up for free
 to join this conversation on GitHub.
 Already have an account?
 Sign in to comment
 
 
 Add this suggestion to a batch that can be applied as a single commit.
 This suggestion is invalid because no changes were made to the code.
 Suggestions cannot be applied while the pull request is closed.
 Suggestions cannot be applied while viewing a subset of changes.
 Only one suggestion per line can be applied in a batch.
 Add this suggestion to a batch that can be applied as a single commit.
 Applying suggestions on deleted lines is not supported.
 You must change the existing code in this line in order to create a valid suggestion.
 Outdated suggestions cannot be applied.
 This suggestion has been applied or marked resolved.
 Suggestions cannot be applied from pending reviews.
 Suggestions cannot be applied on multi-line comments.
 Suggestions cannot be applied while the pull request is queued to merge.
 Suggestion cannot be applied right now. Please check back later.
 
 
 
 
checkCooldownAndFlushAfterPersitingmethod name tocheckCooldownAndFlushAfterPersisting