-
-
Notifications
You must be signed in to change notification settings - Fork 153
chore: replace hostName with fqdnOrHostName #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modules that accept a mere networking.hostName but prefer a fully qualified domain name may use networking.fqdnOrHostName instead.
https://search.nixos.org/options?channel=unstable&show=networking.fqdn&query=networking.fqdn
9ad3797 to
6f3a5a4
Compare
I haven't had the time to test yet, will do in the next days...
I haven't had the time to test yet, will do in the next days...
Ok works. Now this change works without breaking changes if networking.domain is NOT set.
If I am correct, systems that have a domain set will still encounter breaking changes, right?
How should we proceed?
@astro how do we could handle this?
Also the CI tests are failing for some reason I did not grasp yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change only if networking.domain is defined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splitting will lead to conflicts between vm.example.com and vm.example.org which I assumed this PR was going to solve. I guess we should rather escape here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this conflict? In my tests I couldn't find any issues with it
Using fully qualified domain names as unique identifier for containers improves identification of containers on large (potentially multi tenant) hypervisors.
In the current version using a container name containing a dot doesn't work. I forked microvm.nix and adjusted it so that fqdn's are used by default.
Should we try to upstream this? If yes how?
I drafted this change because merging this would result in breaking changes if
networking.domainis being set for a machine.