-
Notifications
You must be signed in to change notification settings - Fork 27
CHORE: Update PR Template to auto-close tasks #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the PR template to include auto-closing keywords for both ADO work items and GitHub issues, enabling automatic closure when PRs are merged.
Key Changes
- Added "Closed" keyword before ADO work item references
- Added "Closes" keyword before GitHub issue references
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📊 Code Coverage Report
🔥 Diff Coverage
100%
🎯 Overall Coverage
74%
📈 Total Lines Covered: 4181 out of 5612
📁 Project: mssql-python
Diff Coverage
Diff: main...HEAD, staged and unstaged changes
No lines with coverage information in this diff.
📋 Files Needing Attention
📉 Files with overall lowest coverage (click to expand)
mssql_python.pybind.connection.connection.cpp: 67.6% mssql_python.ddbc_bindings.py: 68.5% mssql_python.pybind.ddbc_bindings.cpp: 69.3% mssql_python.pybind.connection.connection_pool.cpp: 78.9% mssql_python.cursor.py: 79.7% mssql_python.connection.py: 81.7% mssql_python.helpers.py: 84.7% mssql_python.auth.py: 85.3% mssql_python.type.py: 86.8% mssql_python.pooling.py: 87.5%
🔗 Quick Links
Instead of closing, we should target updating the Issue with a comment saying the PR fix has been merged and this will be released in the next release cycle. And then close the issue.
Uh oh!
There was an error while loading. Please reload this page.
Work Item / Issue Reference
Summary
This pull request updates the pull request template to clarify how references to work items and issues should be formatted. The changes help ensure that references are properly closed when the pull request is merged.
Improvements to reference formatting:
Closed AB#<WORK_ITEM_ID>instead ofAB#<WORK_ITEM_ID>.Closes GitHub Issue: #<ISSUE_NUMBER>instead ofGitHub Issue: #<ISSUE_NUMBER>.