-
Notifications
You must be signed in to change notification settings - Fork 35
feat: add the option to add an error to an ActivityResult #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @MarvinSchenkel,
Awesome addition, we definitely missed this error attribute. Would you be able to test this functionality by adding another test case in tests/unit/functions/test_data_factory_testing_framework_expression_evaluator.py as a param of def test_evaluate.
That would be great, thanks for the work!
Hi @MarvinSchenkel,
Awesome addition, we definitely missed this
errorattribute. Would you be able to test this functionality by adding another test case intests/unit/functions/test_data_factory_testing_framework_expression_evaluator.pyas a param ofdef test_evaluate.That would be great, thanks for the work!
Happy to! However, having some issue with getting the tests to run locally. What I did:
- Installed the project with
poetry install --with dev - Running tests with:
poetry run coverage run --source=src -m pytest . - Error:
ModuleNotFoundError: No module named 'data_factory_testing_framework' - Installed the project in editable mode:
pip install -e "." - Error:
ModuleNotFoundError: No module named 'Microsoft.Azure' - On MacOS with
dotnet --version: 8.0.407 - When setting
coreclras thePYTHONNET_RUNTIME, I can import basic .NET classes:
>>> from System import String
>>> String
<class 'System.String'>
However:
>>> import Microsoft.Azure
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'Microsoft.Azure'
Any idea?
EDIT: dotnet build is required to build the project locally and adding the required .NET dependencies. I will update the dev docs to make this a bit more clear.
@microsoft-github-policy-service agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarvinSchenkel, thank you for your contribution!
Uh oh!
There was an error while loading. Please reload this page.
This PR adds the possibility to mock error messages coming from
ActivityResultswith the status ofFAILED. This will allow users to evaluate expression that depend on the error message, for example:@contains(activity('Fetch some resources').Error.message, 'The specified resource does not exist.')