Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

tools/build.py: Add "path" entry to index.json. #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@dpgeorge
Copy link
Member

@dpgeorge dpgeorge commented Aug 20, 2024

This points to the package's base directory of the within the micropython-lib directory structure.

Copy link
Member Author

@mattytrentini hopefully this is what's needed for mim.

mattytrentini reacted with rocket emoji

This points to the package's base directory of the within the
micropython-lib directory structure.
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge force-pushed the tools-build-add-package-path-to-index branch from 9c1e3c3 to 910af18 Compare August 20, 2024 06:35
Copy link

@dpgeorge This looks like it should do the trick, I'll try this out to generate the json and insert it into mim to sanity check the path but should be great.

For reference, mim currently uses https://wb5lsudgvpt4f4j4pxomg5z3ui0dcgjt.lambda-url.ap-southeast-2.on.aws/ for the current proof of concept, where we've injected the url value into the existing json object by trawling the repo. Will be much nicer to use the official json directly!

Copy link

Added support for this parameter into mim and generated the json from this repo to test against and found it to be working as expected (from the spot checks I did), including things like finding the aioble README that was missed with my naive implementation. Thanks @dpgeorge !

@dpgeorge dpgeorge merged commit 910af18 into micropython:master Aug 22, 2024
@dpgeorge dpgeorge deleted the tools-build-add-package-path-to-index branch August 22, 2024 02:56
Copy link
Member Author

@HowManyOliversAreThere thanks for testing, great that it works! Now merged.

mattytrentini reacted with hooray emoji

Copy link
Contributor

@dpgeorge when will this appear at https://micropython.org/pi/v2/index.json? I had thought it would update the build machine overnight but I'm seeing v1...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattytrentini mattytrentini Awaiting requested review from mattytrentini

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /