-
Notifications
You must be signed in to change notification settings - Fork 1.1k
usb-device-keyboard: Fix ; and ` keycode names. #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dpgeorge
merged 1 commit into
micropython:master
from
dpgeorge:usb-keyboard-fix-keycode-names
Jul 5, 2024
Merged
usb-device-keyboard: Fix ; and ` keycode names. #889
dpgeorge
merged 1 commit into
micropython:master
from
dpgeorge:usb-keyboard-fix-keycode-names
Jul 5, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should be named as the un-shifted version. Signed-off-by: Damien George <damien@micropython.org>
@projectgus FYI
LGTM! I double checked the USB "HID Usages and Descriptions" document (section 10
"Keyboard/Keypad Page (0x07)") and it describes them as "Keyboard ; and :" and "Keyboard Grave Accent and Tilde", so this is the right fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They should be named as the un-shifted version.