Search code, repositories, users, issues, pull requests...

Copy link

Contributor

@iabdalkader iabdalkader commented Dec 30, 2022 •

edited

Loading

Add HS3003 driver.
Add BMM150 driver.
Add BMI270 driver.
Refactor LSM9 driver.
Refactor LSM6 driver.

@iabdalkader iabdalkader force-pushed the new_sensors branch from 8a7800c to 34ff618 Compare

December 30, 2022 18:24

Copy link

Contributor Author

iabdalkader commented Feb 2, 2023

@dpgeorge Any feedback on this 🙏🏼 ?

jimmo

jimmo reviewed

Feb 8, 2023

Copy link

Member

@jimmo jimmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iabdalkader !

micropython/drivers/imu/bmi270/bmi270.py Outdated Show resolved Hide resolved

micropython/drivers/imu/bmi270/manifest.py Show resolved Hide resolved

micropython/drivers/imu/bmi270/bmi270.py Outdated Show resolved Hide resolved

micropython/drivers/imu/bmm150/bmm150.py Outdated Show resolved Hide resolved

micropython/drivers/imu/lsm9ds1/lsm9ds1.py Outdated Show resolved Hide resolved

micropython/drivers/sensor/hs3003/manifest.py Show resolved Hide resolved

micropython/drivers/sensor/hs3003/hs3003.py Show resolved Hide resolved

micropython/drivers/imu/lsm9ds1/lsm9ds1.py Outdated Show resolved Hide resolved

@iabdalkader iabdalkader force-pushed the new_sensors branch 3 times, most recently from 49d20f0 to 3559ce7 Compare

February 13, 2023 13:45

ports/nrf/boards: Add support for ARDUINO NANO33 BLE REV2 chipset. micropython/micropython#10743

Copy link

Contributor Author

iabdalkader commented Feb 13, 2023

@jimmo I fixed all of the review comments, I think, and I retested the drivers.

@iabdalkader iabdalkader force-pushed the new_sensors branch from 3559ce7 to fb9c148 Compare

February 13, 2023 14:22

@iabdalkader iabdalkader mentioned this pull request

Feb 13, 2023

Closed

1 task

dpgeorge

dpgeorge reviewed

micropython/drivers/imu/bmm150/bmm150.py Outdated Show resolved Hide resolved

dpgeorge

dpgeorge reviewed

micropython/drivers/sensor/hs3003/hs3003.py Outdated Show resolved Hide resolved

dpgeorge

dpgeorge reviewed

micropython/drivers/imu/lsm9ds1/lsm9ds1.py Outdated Show resolved Hide resolved

jimmo

jimmo reviewed

micropython/drivers/imu/bmi270/bmi270.py Outdated Show resolved Hide resolved

@iabdalkader iabdalkader force-pushed the new_sensors branch 3 times, most recently from cb8b362 to 87fdc3e Compare

February 15, 2023 15:54

Copy link

Contributor Author

iabdalkader commented Feb 15, 2023

@jimmo @dpgeorge I retested this and everything seems fine, it should be ready now, but let me know if I missed anything!

dpgeorge

dpgeorge reviewed

Feb 16, 2023

micropython/drivers/imu/bmm150/bmm150.py Outdated Show resolved Hide resolved

micropython/drivers/imu/lsm9ds1/lsm9ds1.py Outdated Show resolved Hide resolved

@iabdalkader iabdalkader force-pushed the new_sensors branch 4 times, most recently from bc8013b to 11e81c3 Compare

February 17, 2023 08:42

Copy link

Contributor Author

iabdalkader commented Feb 17, 2023

Updated.

iabdalkader added 5 commits

February 18, 2023 15:50


 hs3003: Add new relative humidity and temperature sensor driver.

203e1e6

Renesas HS3003 Humidity and Temperature sensor driver.


 lsm6dsox: Refactor driver.

e88aa3a

Changes are:
- fix typos
- make constants global
- rename functions with double underscore to single underscore
- rename __init__ keyword argument cs_pin -> cs
- rename read_mlc_output() -> mlc_output()
- rename read_gyro() -> gyro()
- rename read_accel() -> accel()
- update manifest


 lsm9ds1: Refactor driver.

bf8b3c0

Changes are:
- fix typos
- simplify the driver init code
- support setting the magnetometer ODR separately
- update manifest


 bmi270: Add new IMU driver.

92854c1

For the BOSCH BMI270 IMU.