-
Notifications
You must be signed in to change notification settings - Fork 1.1k
urllib.parse : parse.py requires collections.defaultdict class. #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...class is available in the collections.defaultdict module, which was not listed in the dependencies.
Thanks, there're 2 ways to handle such cases: 1) please report them as bugs and I'll fix them; 2) if you'd like to submit PRs, please follow contribution requirements exactly.
urllib.parse : - should not be a space before ":"
urllib.parse : parse.py requires - "parse.py" kinda tautology here, you already said it's urllib.parse.
Suggested commit message:
urllib.parse: Requires collections.defaultdict class.
You can change commit message with "git rebase -i HEAD^", then force-push with "git push -f". More info here: https://github.com/micropython/micropython/wiki/DevelWorkflow . Thanks.
I think it will be quicker if you fix this directly into the main repo.
Le 16 nov. 2015 à 06:52, Paul Sokolovsky notifications@github.com a écrit :
Thanks, there're 2 ways to handle such cases: 1) please report them as bugs and I'll fix them; 2) if you'd like to submit PRs, please follow contribution requirements exactly.
urllib.parse : - should not be a space before ":"
urllib.parse : parse.py requires - "parse.py" kinda tautology here, you already said it's urllib.parse.
Suggested commit message:
urllib.parse: Requires collections.defaultdict class.
You can change commit message with "git rebase -i HEAD^", then force-push with "git push -f". More info here: https://github.com/micropython/micropython/wiki/DevelWorkflow . Thanks.—
Reply to this email directly or view it on GitHub.
Done in bba8fb1
The defaultdict class is available in the collections.defaultdict module, which was not listed in the dependencies.