-
Couldn't load subscription status.
- Fork 1.1k
umqtt.simple: Close old socket on connect #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes the old socket of the client if one is present during a connection attempt to prevent the initialization of multiple sockets when the function is called repeatedly.
elvis-epx
commented
Nov 26, 2022
This PR is important because in ESP32 the maximum number of sockets is around 8 or 10, so if the old sockets are not explicitly closed or garbage-collected, they pile up until no new connections are possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes the old socket of the client if one is present during a connection attempt to prevent the initialization of multiple sockets when the function is called repeatedly. It comes in handy if properly disconnecting from the broker isn't possible.