-
Couldn't load subscription status.
- Fork 1.1k
Supported socket timeout #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@pfalcon ping
Not all MicroPython ports support socket.settimeout (notably the unix port). So this won't work.
Maybe we can reflect this in docs/comments? I'll change the code so that the .settimeout invokes only if the value is passed. It's better to allow this at least on some platforms rather than force the lib's modifications, isn't it?
@dpgeorge, Hey, what's the status?
NJannasch
commented
Jun 18, 2019
push
Uh oh!
There was an error while loading. Please reload this page.
I really need timeout, please merge.
I'm not sure that the behavior does not change, but maybe it's a good idea to set the default timeout to a kind of 30 seconds