Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Supported socket timeout #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Himura2la wants to merge 2 commits into micropython:master
base: master
Choose a base branch
Loading
from Himura2la:patch-1
Open

Conversation

@Himura2la
Copy link

@Himura2la Himura2la commented Nov 23, 2017
edited
Loading

I really need timeout, please merge.

I'm not sure that the behavior does not change, but maybe it's a good idea to set the default timeout to a kind of 30 seconds

devxpy and NJannasch reacted with thumbs up emoji
Copy link
Author

@pfalcon ping

@Himura2la Himura2la changed the title (削除) Supported connection timeout (削除ここまで) (追記) Supported socket timeout (追記ここまで) Dec 20, 2017
Copy link
Member

Not all MicroPython ports support socket.settimeout (notably the unix port). So this won't work.

Copy link
Author

Maybe we can reflect this in docs/comments? I'll change the code so that the .settimeout invokes only if the value is passed. It's better to allow this at least on some platforms rather than force the lib's modifications, isn't it?

Copy link
Author

Himura2la commented May 3, 2018
edited
Loading

@dpgeorge, Hey, what's the status?

Copy link

push

Himura2la reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /