-
Notifications
You must be signed in to change notification settings - Fork 1.1k
umqtt.{robust,simple}: wait_msg(): select blocking mode by parameter #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Knowing the blocking state in wait_msg() allows easier overwriting of the wait_msg() method in subclasses like umqtt.robust. Since the blocking mode of the socket can not be read, a additional parameter is used.
Since, after reconnect the blocking mode of the socket is lost, check_msg() will block like wait_msg(). Holding it a separate parameter allows to reapply the wanted blocking mode later on. Please see also the related commit to umqtt.simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #192 ,
check_msg()block after reconnect. Saving the blocking state in a parameter allows to reapply the blocking mode to the socket.This PR did not address the issue that
check_msg()blocks until reconnected.