Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

OutOfMemory Handling Improvement #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phbreitbach wants to merge 3 commits into mergebase:master
base: master
Choose a base branch
Loading
from generaliinformatik:generaliOomFix

Conversation

@phbreitbach
Copy link

@phbreitbach phbreitbach commented Jan 17, 2022
edited
Loading

Dear Mergebase / Dear @juliusmusseau ,

we had the pleasure to use your log4j-detector tool as complentary scanning tool and would like to contribute some improvements as Pull Request (from our point of view). Please note that we've run the tool automatically on some thousand notebooks so our changes are quite hardened and also we needed a configuration working for all of them.

This Pull Request improves OutOfMemory's handling as in #7
We added a catch block for OutOfMemoryError to catch the case there's one ZIP file too big to be processed in memory. Then the tool will not abort but proceed with the remaining files until a threshold is reached. The threshold is specified as corresponding command line switch.

Please feel free to indicate wether you would like changes in the PR, I will consider to implement them.
Also I am willing to sufficiently grant you "copyright" so you can use the code of this PR as you like, so just send me whatever confirmation you need and I will have a friendly look ...

I have a further PR in the Pipeline for handling of symlinks and maybe even one more for #82 .

I hope this is helpful and I am looking forward for your feedback :-)

Cheers,
Philipp

jangraefen reacted with thumbs up emoji
Catch OOM to cancel the processing of the offending file but continue to do the filewalk
Introducing --oomThreshold Switch
@phbreitbach phbreitbach changed the title (削除) Generali OutOfMemory Handling Improvement (削除ここまで) (追記) OutOfMemory Handling Improvement (追記ここまで) Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /