-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Enhance camera QR scanning robustness for mobile photography #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mebjas <3007365+mebjas@users.noreply.github.com>
Copilot
AI
changed the title
(削除) [WIP] Unable to recognize QR codes captured through mobile phone photography (削除ここまで)
(追記) Enhance camera QR scanning robustness for mobile photography (追記ここまで)
Jul 23, 2025
Copilot finished work on behalf of
mebjas
July 23, 2025 04:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Problem
Users reported that QR codes captured through mobile phone photography could not be recognized, while the same QR codes uploaded as image files worked perfectly. This created an inconsistent and frustrating user experience.
Root Cause
The issue was caused by different decoding algorithms being used for camera vs file scanning:
decodeRobustlyAsync()- provides fallback decoding for challenging conditionsdecodeAsync()- prioritizes speed over robustnessMobile phone photography creates challenging conditions for QR code recognition:
Solution
Enhanced the
scanContext()method inhtml5-qrcode.tsto use a two-tier fallback approach:decodeAsync()for optimal performance on clear QR codesdecodeRobustlyAsync()for challenging conditionsBenefits
Testing
Screenshots
Test Interface Showing Enhanced Functionality:
Enhanced Scanner Interface
The test interface demonstrates both camera and file scanning capabilities, with the enhanced camera scanning now providing the same robust decoding that was previously only available for file uploads.
Fixes #981.
💬 Share your feedback on Copilot coding agent for the chance to win a 200ドル gift card! Click here to start the survey.