-
-
Couldn't load subscription status.
- Fork 96
Remove spread operator in object diffs to increase performance #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Possibly equivalent to #47? It was closed for some reason.
Codecov Report
@@ Coverage Diff @@ ## main #64 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 7 7 Lines 99 109 +10 Branches 36 36 ========================================= + Hits 99 109 +10
Continue to review full report at Codecov.
|
39ab80f to
70aa278
Compare
70aa278 to
1d430f4
Compare
Thanks @SheneekaW will get this published ASAP
Motivation and Context
While using detailedDiff from this library, ran into an issue where large enough files would cause functions to just hang. After updating the object value assignments and removing the spread operator (...), the performance improved.
**Note did not remove the spread operator from the array function or smaller utility functions.
image
Relied on the following functions for timing and heap usage:
How Has This Been Tested?
While making changes, made sure test suite was still good with
npm testruns