Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove spread operator in object diffs to increase performance #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattphillips merged 1 commit into mattphillips:main from SheneekaW:remove-spread-op
Jan 25, 2022

Conversation

@SheneekaW
Copy link
Contributor

@SheneekaW SheneekaW commented Jun 2, 2021

Motivation and Context

While using detailedDiff from this library, ran into an issue where large enough files would cause functions to just hang. After updating the object value assignments and removing the spread operator (...), the performance improved.

**Note did not remove the spread operator from the array function or smaller utility functions.

image

Relied on the following functions for timing and heap usage:

console.time()
console.timeEnd()
process.memoryUsage()

How Has This Been Tested?

While making changes, made sure test suite was still good with npm test runs

Copy link

coveralls commented Jun 2, 2021
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3c6c607 on SheneekaW:remove-spread-op into 6296889 on mattphillips:master.

Copy link
Contributor

anko commented Jun 5, 2021

Possibly equivalent to #47? It was closed for some reason.

Copy link

codecov-commenter commented Jan 25, 2022
edited
Loading

Codecov Report

Merging #64 (70aa278) into main (8c09976) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 70aa278 differs from pull request most recent head 1d430f4. Consider uploading reports for the commit 1d430f4 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## main #64 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 7 7 
 Lines 99 109 +10 
 Branches 36 36 
=========================================
+ Hits 99 109 +10 
Impacted Files Coverage Δ
src/added.js 100.00% <100.00%> (ø)
src/deleted.js 100.00% <100.00%> (ø)
src/diff.js 100.00% <100.00%> (ø)
src/updated.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c09976...1d430f4. Read the comment docs.

Copy link
Owner

Thanks @SheneekaW will get this published ASAP

SheneekaW reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /