Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use triple equals for dates #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JamesGelok wants to merge 1 commit into mattphillips:main from JamesGelok:patch-1
Closed

Use triple equals for dates #61

JamesGelok wants to merge 1 commit into mattphillips:main from JamesGelok:patch-1

Conversation

@JamesGelok
Copy link

@JamesGelok JamesGelok commented Jan 21, 2021

Not sure what would need to be coerced here, triple equals might help ensure a more accurate diff.

sample source

const date1 = new Date(Date.UTC(96, 1, 2, 3, 4, 5));
console.log(date1.valueOf());
// expected output: 823230245000
const date2 = new Date("02 Feb 1996 03:04:05 GMT");
console.log(date2.valueOf());
// expected output: 823230245000

After looking at this I'm thinking we should use triple equals here.

console.log(date1.valueOf() === date2.valueOf());
// expected output: true

anko reacted with thumbs up emoji
Not sure what would need to be coerced here, triple equals might help ensure a more accurate diff. 
```js
 const date1 = new Date(Date.UTC(96, 1, 2, 3, 4, 5));
 console.log(date1.valueOf());
 // expected output: 823230245000
 const date2 = new Date("02 Feb 1996 03:04:05 GMT");
 console.log(date2.valueOf());
 // expected output: 823230245000
 console.log(date1.valueOf() === date2.valueOf());
 // expected output: true
```
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 49e6212 on JamesGelok:patch-1 into 6296889 on mattphillips:master.

@JamesGelok JamesGelok closed this by deleting the head repository Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /