-
Couldn't load subscription status.
- Fork 14
Fixing path issue (to also run on MATLAB Online) and some minor typos #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...names in the helper .m file.
... unnecessary, and without them, it works both online and on desktop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge.
Fwiw, I sort of prefer i.e. & e.g. without the trailing commas which seem like far too much punctuation. But I've learned the grammar gods overruled me on this one ̄_(ツ)_/ ̄
Thanks for reviewing this, @vijayiyer05 - I don't seem to have write permissions to merge this - would you mind please doing so?
@vijayiyer05 - thanks for providing maintainer access - I'll merge and then check to make sure nothing is broken (I checked earlier in my repository, but just in case). Thanks!
This is tested on both desktop and online. To load this on MATLAB online, use:
websave("brainMRIexample", "https://github.com/matlab-deep-learning/Brain-MRI-Age-Classification-using-Deep-Learning/archive/refs/heads/master.zip")
Thanks for all the help!
@vijayiyer05 - I've made a few changes here - specifically, the helper prepare2DImageDataset file is updated to not error on line 63 when run on MATLAB Online - earlier, it used to trip up on the '/'s - possibly due to running it on a linux filesystem.
Other minor changes include some typos fixed. Unfortunately, it appears like there are changes in the license and readme files - there are no real changes made to them content wise.
Thanks!