-
Notifications
You must be signed in to change notification settings - Fork 231
fix: Remove circular dependency #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR. The issue's been on the todo list for some time, so I appreciate you taking it on.
There are three changes I would like you to make before we can merge:
- Rebase the PR onto the
mathjax:developbranch (masterbranch always contains the latest stable version) - Move the content of
ts/input/tex/StringUtil.tsintots/util/string.ts. - Move the content of
ts/input/tex/DimensionUtil.tsintots/util/lengths.ts.
That should similarly take care of the circular dependency and will put all the utilities into the module where they actually should go. There might even be some scope for future code rationalisation in lengths.ts.
When bundling mathjax - you are warned that there is a circular dependency: ```shell code: CIRCULAR_DEPENDENCY, message: Circular dependency: node_modules/mathjax-full/js/input/tex/TexParser.js -> node_modules/mathjax-full/js/input/tex/ParseUtil.js -> node_modules/mathjax-full/js/input/tex/TexParser.js ``` This can lead to runtime errors as the bundler has to guess which module to define first. This commit removes this circular dependency. > Note: there are still other circular dependencies in place that should also be fixed: ```shell 1) components/loader.js > components/package.js 2) input/tex/mathtools/MathtoolsConfiguration.js > input/tex/mathtools/MathtoolsMappings.js > input/tex/mathtools/MathtoolsMethods.js > input/tex/mathtools/MathtoolsUtil.js 3) input/tex/mathtools/MathtoolsMethods.js > input/tex/mathtools/MathtoolsUtil.js 4) output/svg.js > output/svg/WrapperFactory.js > output/svg/Wrappers.js > output/svg/Wrapper.js ```
dad5b94 to
dbc3b42
Compare
Hi @zorkow - I've applied the changes you requested - however - I've noted some other circular deps that should also be fixed. I'm a bit time pressed to do all the fixes right now. So we can merge and re-visit, or if you want to keep it all on the branch?
Nice that you guys have already tackled the problem!
The Branch seems to be stable, can it be merged now?
I'm very interested in this and future fixes to this circular deps problem, since I'd like to write an Obsidian Plug-in, which can't compile on Rollup with marp-core (Markdown presentation engine), since it uses mathjax.
My issue is already linked above.
I'm also very time limited currently, but if there's something I can help with, I'll try to give it somewhat prio :)
b77df61 to
1f851dd
Compare
When bundling mathjax - you are warned that there is a circular
dependency:
This can lead to runtime errors as the bundler has to guess which module
to define first.
This commit removes this circular dependency by moving the functions in
ParseUtil that TexParser used into 2 new namespaces.
I'm trying to be consistent with how the modules are laid out.