-
Notifications
You must be signed in to change notification settings - Fork 231
Fix vector arrow positioning for Safari #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## develop #1375 +/- ## =========================================== - Coverage 86.66% 86.66% -0.01% =========================================== Files 338 338 Lines 84384 84389 +5 Branches 4779 3149 -1630 =========================================== + Hits 73131 73132 +1 - Misses 11253 11257 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with zero-width accents in Safari output in CHTML. In the past, fonts made combining accents using 0-width characters that overlapped to the left, but modern browsers now handle combining characters themselves regarded of whether they are 0-width or not. So browsers differ on how they handle combining characters, and in particular on how the zero-width characters are displayed.
For this reason, MathJax uses the spacing-modifier Unicode black rather than the Combining Diacritical Marks block whenever possible. This works well for most cases, except there is no Spacing Modifier version of the vector arrow, U+20D7, so that has been a perennial problem for MathJax. I thought I had taken care of this in v3, but either that was lost in changes for v3, or it was font-specific (I think it was the latter, where I made a full width vector arrow rather than a zero one in order to work around this problem). With the new fonts, the vector arrow is not longer properly placed when viewed from Safari (but is for other browsers). This is fixed in this PR by additional CSS that resolves the problem in Safari without damaging the position in other browsers (at least in the ones I've tested).
This fixes more than just the U+20D7, but also other combining diacriticals, like U+0303 and the other ones in the 0300 block, e.g.