-
-
Notifications
You must be signed in to change notification settings - Fork 26
Add support for PHPUnit 10 #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
martin-helmich
merged 4 commits into
martin-helmich:master
from
martinssipenko:phpunit10
Mar 3, 2023
Merged
Add support for PHPUnit 10 #52
martin-helmich
merged 4 commits into
martin-helmich:master
from
martinssipenko:phpunit10
Mar 3, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@martin-helmich Hey, could you please take a look at this?
@martinssipenko
martinssipenko
changed the title
(削除) Add support for PHPunit 10 (削除ここまで)
(追記) Add support for PHPUnit 10 (追記ここまで)
Feb 27, 2023
martin-helmich
martin-helmich
approved these changes
Mar 3, 2023
👍 LGTM; thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
These changes add support for PHPUnit version 10.
I've changed the CI pipeline to not execute tests for PHPUnit 10 on PHP 8.0 because PHPUnit 10 requires the PHP version to be at least 8.1.
I've also updated PHPUnit configuration XML file as an invalid config file leads to a non-zero exit code on PHPUnit 10.
Fixes #51