Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update v2 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SoftCreatR wants to merge 1 commit into martin-helmich:v2 from SoftCreatR:v2
Closed

Update v2 #36

SoftCreatR wants to merge 1 commit into martin-helmich:v2 from SoftCreatR:v2

Conversation

@SoftCreatR
Copy link
Contributor

@SoftCreatR SoftCreatR commented Nov 2, 2020

  • Replace flow/jsonpath with softcreatr/jsonpath
  • Replace Travis with Github actions

Copy link
Owner

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍 I'd forgotten about the v2 branch -- however, since both PHP 7.1 and PHPUnit 7 have been EOL for quite some time, it might be time to drop support for this branch, as well. Maybe we can get this merged (see discussions) to get this branch up-to-date (within its declared compatibility matrix) for a final v2 release and after that let it rest in peace.

@@ -0,0 +1,47 @@
---
name: Unit tests
Copy link
Owner

@martin-helmich martin-helmich Dec 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I'd add the same comments as in #38 -- maybe put this on the back burner, until #38 is resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-helmich martin-helmich martin-helmich left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /