-
-
Notifications
You must be signed in to change notification settings - Fork 26
Update composer.json to allow PHP 8 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for this PR! Unfortunately, after enabling the actual pipelines for this PR, I've noticed that currently Composer is not able to resolve a compatible set of dependencies for this project for PHP 8 -- mainly because there's no PHP 8-compatible version of phpspec/prophecy (already tracked at phpspec/prophecy#491). So there's no way the new CI jobs would pass with PHP 8.
I'll sit on this for a while -- hopefully, this'll resolve itself in the next few days.
Oh, and we'd also need to exclude the "PHP 8"+"PHPUnit 8" combination from the build matrix, since PHPUnit 8 is declared to be compatible with PHP ^7.2, only.
Thanks for the review! I made it such so failures on 8.0 would not affect the entire build. This should work, but let me try with something else too.
Alright, it is as good as it gets. Hope you can squash-merge it.
I added a pretty name for the builds, you might want to update your protected branch configuration. Or we can restore the old naming scheme.
👍 Looking good! Thanks for your contribution.
No description provided.