-
Notifications
You must be signed in to change notification settings - Fork 359
Openssl #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Openssl #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi fpm-peter,
Thank you for your contribution.
I'll add zlib also to the build script. Otherwise, the script will fail on some systems. Please let me know if the script still works for you after I made the changes.
Hi Markus,
tested it successfully in Docker and on Ubuntu 18.04.
Danke für die Arbeit am Skript und viele Grüße aus Malmö
Ja gerne!
Viele Grüße aus München :-)
... On 21. Aug 2019, at 11:55, Peter ***@***.***> wrote:
Hi Markus,
tested it successfully in Docker and on Ubuntu 18.04.
Danke für die Arbeit am Skript und viele Grüße aus Malmö
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#31?email_source=notifications&email_token=AAJJ34KDL557K2DRNKZAYZTQFUGKBA5CNFSM4INRV6T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4ZEBFA#issuecomment-523387028>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJJ34IR6KJH42SXVOXBHLLQFUGKBANCNFSM4INRV6TQ>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point ffmpeg seems to have moved openssl out. So the current build script can't handle https sources.
to reproduce:
docker run ffmpeg -i https://sample-videos.com/video123/mp4/720/big_buck_bunny_720p_1mb.mp4 -f webm -c:v libvpx -c:a libvorbis - > /tmp/test.mp4
Here is a PR where I added a openssl build step, the dependency install for the Dockerfile and the --enable-openssl configuration.