-
-
Notifications
You must be signed in to change notification settings - Fork 7
Initial running version on Windows #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Ugly `cfg` used to disable MacOS-specific code. - `apply_mica` vibrancy looks so bad. - Shortcut's broken. Will investigate soon. This commit is made using commit!!
- Now default shortcut for Windows is usable. - blur effect is broken as well. - Settings shortcut looks broken.
@66Leo66 Amazing work! I've added a build target for Windows on CI, so that anyone else following this (and me once I get back to my PC) can try this out.
I've also switched to using CommandOrControl for the keyboard shortcut, which should hopefully simplify the changes needed to the frontend (tho the module that displays the shortcut still needs some changes, namely displaying Ctrl instead of ⌘, and maybe the Windows key?).
I'm ok with disabling window vibrancy if you can't get it working (we'll have to do this in Linux too I think).
Correct shortcut hint is being displayed in the tray menu now.
Settings shortcut only works when focusing commit's main window. Is this the intended behaviour?
Regarding window vibrancy:
I have found the problem. Making frontend use background: transparetn is required to see the effects.
However, since we are using https://github.com/tauri-apps/window-vibrancy, here's the situation:
-
Not on Linux: https://github.com/tauri-apps/window-vibrancy#platform-specific
-
blur is super laggy, don't use
-
arcylic feels okay on
Win11 22H2 build 22621. Haven't tested onWin10 1903+which is said to have bad performance. It reflect the color under the window.
image -
mica won't encounter performance issue, but it's Win11 only and it reflect the color of the wallpaper, so looks bad in some occurences.
image
image
Make your windows vibrant. Contribute to tauri-apps/window-vibrancy development by creating an account on GitHub.
Make your windows vibrant. Contribute to tauri-apps/window-vibrancy development by creating an account on GitHub.
Related: #5
Added compiler macros to isolate platform-specific code, allowing it to compile on Windows.
Working:
Not working:
image
image
image