-
Notifications
You must be signed in to change notification settings - Fork 19
Add PHP@5.6 Support #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lkaybob
Copy link
Owner
@lkaybob
lkaybob
commented
May 22, 2018
- Removed class constant visibility syntax, which is availaible form PHP@7.1. See the link
- Updated composer.json & .travis.yml. Deleted composer.lock
* 'Already in use' issue found during PHP@5.6 Test * Changed GuzzleHttp's Client instant usage to GuzzleHttp\Client
* Removed PHP@7.2's syntax (ex. Class constant's visibility)
* Updated to test PHP@5.6 in .travis.yml * Updated composer.json. Changed PHP version constraint from ^5.6 to >= 5.6 * Deleted composer.lock (Maybe affected some collisions)
* Removed PHP@7.2's syntax
codecov-io
commented
May 22, 2018
Codecov Report
@@ Coverage Diff @@ ## master #2 +/- ## ============================================ + Coverage 93.71% 93.84% +0.12% Complexity 62 62 ============================================ Files 8 8 Lines 191 195 +4 ============================================ + Hits 179 183 +4 Misses 12 12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.