-
Notifications
You must be signed in to change notification settings - Fork 19
feat: set image for android notification #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set image for android notification #19
Conversation
Guess there's something wrong with GitHub Actions. I'll look into it and make sure the action runs properly.
@mgcastelberg Sorry for the delay. I guess I found the issue.
In my GA manifest, there is a step that decrypts encrypted service account file(service_account.json.gpg), which requires repository secret. Github Actions does allow repository secrets to be shared with forked repository for specific event(pull_request_target), but it requires Github Actions manifest file to be updated.
So I guess there should be two options so far.
Option 1) Rebasing merge request.
I update the GA manifest file on master branch first, and then you rebase your working branch to updated master branch. This method is canonical way to do in my opinion. Although it requires few tricky local git commands on both sides, this would definitely make sure that GA works fine.
Option 2) Temporarily set secret on your side
As a workaround other than first option, I can share you the secret, and you set it on your forked repository. This one does not require git interactions, but I'm not sure this method would work, but at least we can try.
If option 2 works, I will update encrypted service account file with different passphrase and GA manifest file, so that you can work on iOS part. (Of course, if option 2 does not work, we should stick to first options :( )
Please let me know which do you prefer at first.
@mgcastelberg Thank you for your understanding. Let's try second option first.
Could you send me an email to hello@lkaybob.pe.kr? (Since I can't see email address on your Github profile)
After you sending me an email, I will reply with passphrase and a guide to set secret on forked reository.
@mgcastelberg Sorry for the delay. I was busy for a while, and I've done some research on first option that I suggested, since second option didn't go well.
It seems Github Actions does not work as I understood, so restoring GA workflow would need additional administrative actions. (ex. Changing mechanism to test library with actual service account.)
I will assume your code runs well, so let's merge after my review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to leave your opinion on the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once approved, I will perform a couple of tests from my project to verify that everything is in order.
Thank you for your contribution. @mgcastelberg
I'm planning to create a release after your next contribution, since you are planning to add image send support for iOS. If you want to test the merged code so far, I guess you have to specify your project's composer to get package from master branch.
FYI. Tests ran successfully after the merge.
https://github.com/lkaybob/php-fcm-v1/actions/runs/7043311400/job/19168864687
Goal
Send image on android notification