-
Notifications
You must be signed in to change notification settings - Fork 717
Fix hostresolver setting for VZ, but disable it by default #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3c022c5 to
af9f666
Compare
af9f666 to
211fefe
Compare
I believe this PR is working correctly.
Unfortunately it didn't help in tracking down the DNS issue with VZ1 because it seems to happen with both HostResolver and with the gvisor-tap-vsock resolver, but that is a separate problem.
Footnotes
-
It is a relatively obscure failure that happens in
CoreDNSwhen usingkindwith ausernetnetwork whilehost.docker.internalis defined to point tohost.lima.internal. It doesn't happen with QEMU, so maybe a bug ingvisor-tap-vsock, but still not clear. ↩
211fefe to
49a83b5
Compare
Since it was implicitly disabled for VZ, we cannot simply fix the bug, but change the default to match the previous de-facto default. See lima-vm#4089 for more info. Signed-off-by: Jan Dubois <jan.dubois@suse.com>
49a83b5 to
c68049e
Compare
It is suspicious that the QEMU integration test with the user-v2 network keeps failing.
It does pass for me locally, fwiw.
==> /home/runner/.lima/net-user-v2/serial.log <==
[ 387.917819] cloud-init[1040]: libsubid4 uidmap
[ 417.955457] cloud-init[1040]: 0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.
[ 417.958231] cloud-init[1040]: Need to get 49.4 kB of archives.
[ 417.959752] cloud-init[1040]: After this operation, 208 kB of additional disk space will be used.
[ 417.961866] cloud-init[1040]: Ign:1 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 libsubid4 amd64 1:4.13+dfsg1-4ubuntu3.2
[ 447.985053] cloud-init[1040]: Ign:2 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 uidmap amd64 1:4.13+dfsg1-4ubuntu3.2
[ 478.020751] cloud-init[1040]: Ign:1 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 libsubid4 amd64 1:4.13+dfsg1-4ubuntu3.2
[ 508.049158] cloud-init[1040]: Ign:2 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 uidmap amd64 1:4.13+dfsg1-4ubuntu3.2
[ 538.083405] cloud-init[1040]: Ign:1 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 libsubid4 amd64 1:4.13+dfsg1-4ubuntu3.2
[ 568.115833] cloud-init[1040]: Ign:2 http://archive.ubuntu.com/ubuntu noble-updates/main amd64 uidmap amd64 1:4.13+dfsg1-4ubuntu3.2
https://github.com/lima-vm/lima/actions/runs/18024105718/job/51444457681?pr=4090
It does pass for me locally, fwiw.
I can reproduce the problem even on macOS when explicitly asking for qemu:
limactl start -y --vm-type qemu ./hack/test-templates/net-user-v2.yaml
It seems like usernet configuration is different between QEMU and VZ.
Uh oh!
There was an error while loading. Please reload this page.
Since it was implicitly disabled for VZ, we cannot simply fix the bug, but change the default to match the previous de-facto default.
This PR now disables HostResolver by default, except for QEMU.
This implements option (1) from #4089.