-
Notifications
You must be signed in to change notification settings - Fork 718
Kata/Docker Container external driver for Linux #3840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
80ffe35 to
484fd03
Compare
pkg/driver/dc/dc_driver_linux.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not call it "docker"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway there must be a clear documentation that clarifies how this differs from template://docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative name for it was Kata Containers, but it was hampered a bit about it (kata) being broken...
Currently there is no way to select the runtime, between runc/runv/runq etc, it is a hardcoded string
But the goal for it was to default to a VM runtime - since it is trying to behave like the Apple Containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative names:
- in-docker
- docker-as-vmdriver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just docker is fine because of the context where it will be used: vmType: docker or --vm-type docker.
pkg/store/instance_linux.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code will be moved to the driver
484fd03 to
af442a4
Compare
af442a4 to
c59ffed
Compare
c59ffed to
63b9523
Compare
63b9523 to
34e340a
Compare
34e340a to
88c5aff
Compare
A new macOS driver similar to the WSL2 driver for Windows, creating virtual machines from container images (as rootfs). Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
A new Linux driver similar to the WSL2 driver for Windows, creating virtual machines from container images (as rootfs). Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
88c5aff to
00e9c30
Compare
Uh oh!
There was an error while loading. Please reload this page.
A new Linux driver similar to the WSL2 driver for Windows,
creating virtual machines from container images (as rootfs).
Depends-On #3839
make native && ADDITIONAL_DRIVERS=dc make additional-drivers(this is a draft, until the driver framework has been finalized)
Intended for use with Kata containers or similar runtime
Not related with
template://docker, inside the instance.