-
Notifications
You must be signed in to change notification settings - Fork 47
Adds lightning-transaction-sync in favor of Confirm #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for lightningdevkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of the examples given in these steps are bindings-specific and would look differently in Rust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agree, generally speaking, the kotlin & swift examples approach things from a mobile-first perspective but I've not seen any simple examples of CBF in a mobile context yet. Hopefully, with BDK 1.0 it's possible. Current mobile users are opting for Esplora/Electrum and we have some coverage there.
Co-authored-by: Elias Rohrer <dev@tnull.de>
c91ff23 to
4f8109a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM.
Not sure if we want to hold off merging this until the next bindings release to immediately include the tx-sync examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Spell out numbers zero to ten.
Basically LGTM.
Not sure if we want to hold off merging this until the next bindings release to immediately include the
tx-syncexamples?
Yeah let's hold off for that, sgtm!
Uh oh!
There was an error while loading. Please reload this page.
Can add examples for kotlin and swift examples once exposed in the bindings.
Also probably worth adding CBF examples once available in BDK 1.0
Closes #249