Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

use .null? to test NULL pointer returns #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcupitt merged 4 commits into master from better-null-test
Jul 17, 2025
Merged

use .null? to test NULL pointer returns #420

jcupitt merged 4 commits into master from better-null-test
Jul 17, 2025

Conversation

@jcupitt
Copy link
Member

@jcupitt jcupitt commented Jul 17, 2025

we were using .nil? in a couple of cases

see #419

thanks dloebl

dloebl reacted with heart emoji 
we were using `.nil?` in a couple of cases
see #419
thanks dloebl
Copy link
Member Author

jcupitt commented Jul 17, 2025

@dloebl I added your coffee GIF to the samples, I hope that's OK.

If anyone could double-check that I got all the possible null pointers, that'd be great.
dloebl reacted with eyes emoji

Copy link

dloebl commented Jul 17, 2025

I added your coffee GIF to the samples, I hope that's OK.

Thanks! That's fine. It's a public domain (CC0) image I got from here and altered some bytes to make it invalid: https://pixabay.com/gifs/coffee-cup-mug-pixel-art-steam-19613

If anyone could double-check that I got all the possible null pointers, that'd be great.

Looks good to me! I've searched through the code as well and wasn't able to find other instances
jcupitt reacted with thumbs up emoji

@jcupitt jcupitt merged commit 726357f into master Jul 17, 2025
22 checks passed
@jcupitt jcupitt deleted the better-null-test branch July 17, 2025 13:19
Copy link
Member Author

jcupitt commented Jul 17, 2025

\o/ thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dloebl dloebl dloebl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /