Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Github standards initial commit #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mesaugat merged 8 commits into develop from github
Jun 22, 2020
Merged

Github standards initial commit #4

mesaugat merged 8 commits into develop from github
Jun 22, 2020

Conversation

@bipenc
Copy link
Contributor

@bipenc bipenc commented May 28, 2020 •
edited
Loading


#### Best Practices:
* Pull Request should atleast be <b>reviewed by 1 person</b> before merging it to the base branch.
* Only comment author can resolve comment – if code was corrected or after discussion author decides to fix it.
Copy link
Member

@mesaugat mesaugat Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be very strict. I think other team members should be able to resolve a comment too.

* `#<transition-name>` : Moves the Jira issue to a particular workflow state.

eg:
* `git commit -m "TEST-34 #time 1w 2d 4h 30m Total work logged"`.
Copy link
Member

@mesaugat mesaugat Jun 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this succinct and let's try not to use TEST-34 as an example.

@mesaugat mesaugat merged commit ba2e932 into develop Jun 22, 2020
@mesaugat mesaugat deleted the github branch June 22, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anishmanandhar anishmanandhar anishmanandhar left review comments

@mesaugat mesaugat mesaugat approved these changes

@kabirbaidhya kabirbaidhya Awaiting requested review from kabirbaidhya

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /