This repository was archived by the owner on Sep 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 144
Fix: address whiteout issue #123
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! A will review this when the update modal will be OK.
Yes it’s pretty weird, I cannot reproduce too...
@lauthieb Ok, I think I am done with thie PR and ready for a review.
- All text input boxes are now required input.
- Create button will not be enabled until all text boxes are filled in, including content.
- Required input boxes, have also the required property on the
b-inputto alert user in the UI.
Tested build on linux and windows.
@lauthieb
lauthieb
changed the title
(削除) WIP: To address whiteout issue (削除ここまで)
(追記) Fix: address whiteout issue (追記ここまで)
Jan 8, 2020
Thank you @kodaman2, I've just made a PR on your branch here TheFern2#2 to simplify the code.
lauthieb
lauthieb
suggested changes
Jan 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check TheFern2#2 to simplify your code :)
refactor: whiteout issue
Please check kodaman2#2 to simplify your code :)
Love the simplication! Merged :)
lauthieb
lauthieb
approved these changes
Jan 8, 2020
Thanks! Merged :)
We will make a new version pretty soon.
Closes #119
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I am updating the modals to inhibit the create buttons if the text input boxes are not filled in. I also need to update the update note modal. I'll let you know when I am done.
This addresses #119 strangely enough it looks like is only an issue with local notes, and only on windows. I tried to recreate on linux/mac with no luck. Regardless I think the create button shouldn't be enabled until all text input is filled in, if anyone have any other thoughts I am all ears. :)