-
Notifications
You must be signed in to change notification settings - Fork 144
Feature/editor full screen mode #103
Conversation
Hi @probil, thanks a lot for this PR.
I’m on vacation sorry but I will review and test your work ASAP.
Thank you
Hi @lauthieb Thanks for response
Take your time :) I'll try to fix other things in the meanwhile
Nice @probil! Thanks a lot for your work on Code Notes.
But on MacOS, I've got this (the editor appears on topbar) :
@lauthieb I'm not an expert in electron but I think there should be some kind of configuration to enable on Mac (similar to windows & linux)
Any ideas?
@probil nope sorry, maybe you should get some advices from the community of our contributors.
Thanks a lot again for this work and sorry for the delay, I haven't so much time for Code Notes now... :(
ebdbaf3 to
29d3a74
Compare
@probil Can you please fix conflicts and update your branch with just your modifications?
Sorry for the inconvenience it was mandatory to force push master after several tries to fix this important bug #110
Here you can download the new version 1.2.3 : https://github.com/lauthieb/code-notes/releases/tag/1.2.3
Thanks a lot in advance for this.
Hi @probil, happy new year 🎉
What about the conflict resolution and this issue?
Do you want to continue this Pull Request?
Thanks a in advance. Have a great day :)
@lauthieb Happy New Year!
yeah, I will rebase it on latest master and resolve conflicts
0e110d9 to
962ecab
Compare
@lauthieb done
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #69
Screenshot from 2019年10月13日 15-14-45
Screenshot from 2019年10月13日 15-15-02