-
-
Notifications
You must be signed in to change notification settings - Fork 56
β¨ π Adding Favicons based on Laravel.io speech box #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure happy with how this came out, but without a proper square logo it may be hard to find something to work well at that small size. Likely looks better on retina devices/mobile than in a desktop browser tab.
Heya! This is a good idea. Until we have a new logo this will serve fine.
But I think we can improve one thing. Atm. the image you sent in will indeed look a little quirky in a browser tab because it's rectangle. In the old forum we did have a favicon which was square. It's still cached on my side so I managed to take a screenshot of it:
screen shot 2017εΉ΄06ζ20ζ₯ at 4 20 50 pm
Do you think you can perhaps update the favicons you sent in to have them look like the square version from the screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor things.
public/images/favicons/manifest.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename "Laravel IO" to "Laravel.io"
public/images/favicons/manifest.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename "Pastbin" to "Pastebin"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, I'm good at typing :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this file to _favicons.blade.php.
Code changes complete, and pushed new versions of a zoomed "IO" logo.
Awesome work man! If you're up for it, you can send the exact same changes to the portal repo. If not, no worries, I'll open up an issue or do the changes myself :)
Will do
Not sure happy with how this came out, but without a proper square logo it may be hard to find something to work well at that small size. Likely looks better on retina devices/mobile than in a desktop browser tab.
Potential solution for #10