Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: update Storybook to latest patterns and modern interaction testing #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaruesink merged 1 commit into main from codegen-bot/update-storybook-to-latest-patterns
Jun 9, 2025

Conversation

@codegen-sh
Copy link
Contributor

@codegen-sh codegen-sh bot commented Jun 9, 2025

Summary

This PR brings the medusa-forms repository in line with the latest Storybook patterns from the forms repository, updating to modern interaction testing capabilities while maintaining compatibility with the Medusa Forms component architecture.

Changes Made

📦 Package Updates

  • Storybook packages: Updated from 9.0.1 to 9.0.6
  • Added @storybook/test: New package for modern interaction testing utilities
  • Test runner: Updated from 0.22.0 to 0.22.1

🛠️ Configuration Improvements

  • simple-server.js: Improved error handling and formatting to match forms repo standards
  • Better CORS headers: Added OPTIONS method support

📚 Documentation & Rules Updates

  • storybook-testing.mdc: Completely updated with modern interaction testing patterns:
    • Added play functions documentation with examples
    • Added canvas queries and Testing Library integration
    • Added userEvent interaction patterns
    • Added step grouping for complex workflows
    • Adapted all examples for react-hook-form + @medusajs/ui context
    • Updated version references from 8.6.7 to 9.0.6
    • Added comprehensive testing workflows for both local development and Codegen

🎯 Key Features Added

  • Modern Interaction Testing: Play functions for simulating user behavior
  • Canvas Queries: Testing Library integration for semantic element selection
  • Step Grouping: Organized testing workflows with visual debugging
  • Accessibility-First Testing: Semantic queries that match user behavior
  • Visual Debugging: Enhanced debugging capabilities in Storybook UI

Testing

Dependencies: All packages install successfully
Build: Storybook builds without errors
Compatibility: Existing stories remain functional

Context

This update mirrors the recent improvements made to the forms repository (PR #97) while adapting the patterns for the medusa-forms context. The changes enable modern interaction testing capabilities while maintaining the existing component architecture using react-hook-form and @medusajs/ui.

Next Steps

After this PR is merged, developers can:

  1. Use the new @storybook/test utilities for interaction testing
  2. Implement play functions in existing stories
  3. Leverage the updated testing patterns documented in the cursor rules
  4. Take advantage of improved debugging capabilities in the Storybook UI

💻 View my workAbout Codegen

- Update Storybook packages from 9.0.1 to 9.0.6
- Add @storybook/test package for modern interaction testing
- Update test-runner to 0.22.1
- Improve simple-server.js error handling and formatting
- Update storybook-testing.mdc with modern interaction testing patterns:
 - Add play functions documentation
 - Add canvas queries and userEvent patterns
 - Add step grouping for complex workflows
 - Adapt examples for react-hook-form + @medusajs/ui context
 - Update version references and testing workflows
This brings medusa-forms in line with the latest Storybook patterns
from the forms repository while maintaining compatibility with the
Medusa Forms component architecture.
Copy link

coderabbitai bot commented Jun 9, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jun 9, 2025

📝 Storybook Preview: View Storybook

This preview will be updated automatically when you push new changes to this PR.

Note: The preview will be available after the workflow completes and the PR is approved for deployment.

@jaruesink jaruesink marked this pull request as ready for review June 9, 2025 02:50
@jaruesink jaruesink merged commit 5590508 into main Jun 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /