-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Move linux/darwin binaries into cache/binaries folder (#21179) #21664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @henry3260. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Can one of the admins verify this patch?
pkg/minikube/download/binary.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use "bin", it is more consistent with ~/.minikube/bin and the rest of the world.
We are using "binaries" internally which would nice to change also to bin but it may be harder since we may code using it. Since this cache directory is new we don't have backward compatibility concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use "bin", it is more consistent with ~/.minikube/bin and the rest of the world.
We are using "binaries" internally which would nice to change also to bin but it may be harder since we may code using it. Since this cache directory is new we don't have backward compatibility concerns.
Thanks for the suggestion! That makes sense, I’ll update it to use bin for consistency.
d3e6101 to
2e7c8cf
Compare
/lgtm
/assign @medyagh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~/.minikube is the default, but if MINIKUBE_HOME is defined it will be used. There is a helper function to return the right path (but I don't remember the function name). Check what other tests are doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, to make it even better squash this commit into the first one. Having this in git history is not helpful.
/lgtm
aa3b2e4 to
fca5789
Compare
/lgtm
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR, please update the before/after (it seems to be outdated)
minikube-pr-bot
commented
Oct 17, 2025
kvm2 driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21664 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 43.3s │ 43.5s │
│ enable ingress │ 16.0s │ 16.1s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube ingress: 15.3s 15.3s 16.4s 15.8s 17.4s
Times for minikube (PR 21664) ingress: 16.9s 16.3s 15.3s 16.3s 15.9s
Times for minikube start: 45.8s 43.6s 42.4s 42.7s 42.0s
Times for minikube (PR 21664) start: 46.1s 41.4s 44.7s 43.5s 41.6s
docker driver with docker runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21664 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 23.3s │ 23.8s │
│ enable ingress │ 11.1s │ 11.9s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube start: 23.3s 23.0s 23.5s 22.5s 24.4s
Times for minikube (PR 21664) start: 27.2s 22.1s 22.0s 25.3s 22.4s
Times for minikube ingress: 10.7s 10.6s 10.7s 12.6s 10.7s
Times for minikube (PR 21664) ingress: 11.7s 11.8s 11.7s 13.7s 10.7s
docker driver with containerd runtime
┌────────────────┬──────────┬────────────────────────┐
│ COMMAND │ MINIKUBE │ MINIKUBE ( PR 21664 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 20.9s │ 20.5s │
│ enable ingress │ 21.5s │ 21.3s │
└────────────────┴──────────┴────────────────────────┘
Times for minikube ingress: 21.1s 22.1s 22.1s 21.1s 21.1s
Times for minikube (PR 21664) ingress: 22.1s 20.2s 21.1s 22.2s 21.1s
Times for minikube start: 21.3s 20.2s 21.2s 20.7s 21.2s
Times for minikube (PR 21664) start: 20.2s 23.5s 19.4s 20.5s 19.0s
minikube-pr-bot
commented
Oct 17, 2025
|
Here are the number of top 10 failed tests in each environments with lowest flake rate.
Besides the following environments also have failed tests:
To see the flake rates of all tests by environment, click here. |
thanks for the PR, please update the before/after (it seems to be outdated)
updated!
|
@henry3260: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
thanks for the PR, please update the before/after (it seems to be outdated)
updated!
It is still outdated:
They are now moved into a dedicated binaries subfolder:
~/.minikube/cache/binaries/linux
~/.minikube/cache/binaries/darwin
thanks for the PR, please update the before/after (it seems to be outdated)
updated!
It is still outdated:
They are now moved into a dedicated binaries subfolder:
~/.minikube/cache/binaries/linux
~/.minikube/cache/binaries/darwin
Thanks for pointing that out! I've corrected it now.
@henry3260 this change broke few test:
=== RUN TestDownloadOnly/v1.28.0/binaries
aaa_download_only_test.go:157: expected the file for binary exist at "/home/jenkins/minikube-integration/21664-14293/.minikube/cache/linux/amd64/v1.28.0/kubelet" but got error stat /home/jenkins/minikube-integration/21664-14293/.minikube/cache/linux/amd64/v1.28.0/kubelet: no such file or directory
aaa_download_only_test.go:157: expected the file for binary exist at "/home/jenkins/minikube-integration/21664-14293/.minikube/cache/linux/amd64/v1.28.0/kubeadm" but got error stat /home/jenkins/minikube-integration/21664-14293/.minikube/cache/linux/amd64/v1.28.0/kubeadm: no such file or directory
aaa_download_only_test.go:157: expected the file for binary exist at "/home/jenkins/minikube-integration/21664-14293/.minikube/cache/linux/amd64/v1.28.0/kubectl" but got error stat /home/jenkins/minikube-integration/21664-14293/.minikube/cache/linux/amd64/v1.28.0/kubectl: no such file or directory
Please run integration tests locally and fix the failing tests.
See https://minikube.sigs.k8s.io/docs/contrib/testing/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix the tests assuming the old location.
The issue is we compute the path manually in the test and in the code. We need a helper to locate the binaries that can be used by the code and the tests.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: henry3260
Once this PR has been reviewed and has the lgtm label, please ask for approval from medyagh. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Uh oh!
There was an error while loading. Please reload this page.
This PR addresses issue #21179 by reorganizing the cache folder structure for binaries.
Before
~/.minikube/cache/linux~/.minikube/cache/darwinAfter
binariessubfolder:~/.minikube/cache/bin/linux~/.minikube/cache/bin/darwinWhy
Fixes #21179
Screenshot (Before)
imageScreenshot (After)
image