Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

don't use cluster scope permissions when metrics auth is disabled #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nirrozenbaum wants to merge 1 commit into kubernetes-sigs:main
base: main
Choose a base branch
Loading
from nirrozenbaum:helm-rbac-metrics

Conversation

@nirrozenbaum
Copy link
Contributor

@nirrozenbaum nirrozenbaum commented Nov 2, 2025

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
when deploying IGW with prometheus.enabled == false, metrics auth is disabled.
in such a case, the filter.WithAuthenticationAndAuthorization will not be called, making the creation of the cluster scope rbac unnecessary.
This PR aims to deploy in local envs using ns scope permissions only.
more details here:

if *metricsEndpointAuth {
return filters.WithAuthenticationAndAuthorization
}
return nil
}(),

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 2, 2025
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • (削除) OWNERS (削除ここまで) [nirrozenbaum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 2, 2025
Copy link

netlify bot commented Nov 2, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 2796d2b
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6907a5b302dded0008af96e5
😎 Deploy Preview https://deploy-preview-1804--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danehans danehans Awaiting requested review from danehans

@kfswain kfswain Awaiting requested review from kfswain

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /