Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add benchmarking folder #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlakhtakia wants to merge 1 commit into kubernetes-sigs:main
base: main
Choose a base branch
Loading
from rlakhtakia:main
Open

Conversation

@rlakhtakia
Copy link
Contributor

@rlakhtakia rlakhtakia commented Oct 7, 2025 •
edited
Loading

What type of PR is this?
/kind documentation

Does this PR introduce a user-facing change?:

NONE

#1688

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/documentation Categorizes issue or PR as related to documentation. labels Oct 7, 2025
Copy link

netlify bot commented Oct 7, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 1f673c5
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68f67c281e35cc00089b7ce2
😎 Deploy Preview https://deploy-preview-1689--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2025
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rlakhtakia
Once this PR has been reviewed and has the lgtm label, please assign nirrozenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rlakhtakia rlakhtakia marked this pull request as draft October 7, 2025 16:21
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2025
Copy link
Contributor

Hi @rlakhtakia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 13, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 13, 2025
@rlakhtakia rlakhtakia changed the title (削除) [WIP] Add benchmarking folder with prefix cache aware set up (削除ここまで) (追記) Add benchmarking folder with prefix cache aware example set up (追記ここまで) Oct 13, 2025
@rlakhtakia rlakhtakia changed the title (削除) Add benchmarking folder with prefix cache aware example set up (削除ここまで) (追記) Add benchmarking folder (追記ここまで) Oct 13, 2025
@rlakhtakia rlakhtakia marked this pull request as ready for review October 13, 2025 17:02
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2025
Copy link
Collaborator

kfswain commented Oct 14, 2025

/ok-to-test

Thanks! Looks good!

Do you mind splitting this up a bit?
We can update the guides here.

And is this looks like a helm chart we are defining for benchmarking, which is great! Have we talked to the inference-perf folks to see if they want to use this?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2025
@rlakhtakia rlakhtakia force-pushed the main branch 3 times, most recently from c4a1086 to b0a2440 Compare October 17, 2025 17:05
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2025
Copy link
Collaborator

kfswain commented Oct 20, 2025

Spoke with @rlakhtakia we are going to try to split some of this work out into different projects (charts to inference perf, readme to our site docs).

/hold

Holding until we have solid next steps there.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2025
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Copy link
Contributor

@rlakhtakia thanks for the contribution. Do you have any updates regarding #1689 (comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kfswain kfswain kfswain left review comments

@danehans danehans Awaiting requested review from danehans

@elevran elevran Awaiting requested review from elevran

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

+1 more reviewer

@liu-cong liu-cong liu-cong left review comments

Reviewers whose approvals may not affect merge requirements

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /