-
Notifications
You must be signed in to change notification settings - Fork 239
Pull function-catalog to have all docs in the same domain #4289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Now you can see function-catalog in the same domain
example
https://deploy-preview-4289--kptdocs.netlify.app/function-catalog/
https://deploy-preview-4289--kptdocs.netlify.app/function-catalog/apply-replacements/v0.1/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also copy the examples folder from $(CLONE_DIR) to content/en/examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CsatariGergely I added them now.
Thank you because I did not notice they were not getting rendered
Looks good, thanks. Is there a way to trigger the build of kpt.dev in case there is a change in krm-functions-catalog?
Looks good, thanks. Is there a way to trigger the build of kpt.dev in case there is a change in krm-functions-catalog?
Right, I haven't thought of this
I am reading from docs we should use this build hook https://docs.netlify.com/build/configure-builds/build-hooks/
So we have a github action in the catalog to do a simple curl to this hook so it will trigger the kpt.dev website build, if there are changes to the catalog-docs.
I can generate a PR for the catalog repo, but an OWNER might need to create a secret with the netlify build hook url from kpt.dev site (kpt.dev site on Netlify: Site settings -> Build & deploy -> Build hooks)
Looks good, thanks. Is there a way to trigger the build of kpt.dev in case there is a change in krm-functions-catalog?
@CsatariGergely kptdev/krm-functions-catalog#1187 added this, but I am assuming an OWNER can create that variable
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
71447f6 to
84a8f49
Compare
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Uh oh!
There was an error while loading. Please reload this page.
The makefile will clone the function catalog repo and copy over only function runner folder doc and it's javascript