-
Notifications
You must be signed in to change notification settings - Fork 5k
A bit simplified code and update to Swift 5.1 #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In Horspool version we need skip ahead full pattern length (or less if character already met) when it not full match pattern So in Horspool version we need need correctly fill length of skip of last character in pattern
At Swift 5.1 we can use built in hash function, so there is no need to use custom realisation We just need to use overflow operators to not overflow Int All code the same except hash function
@pkamb
pkamb
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation was changed from 4 spaces to 2 spaces, hiding any changes in this commit diff.
Style guide does say to use 2 spaces...
But I would suggest fixing the indenting in a separate commit and/or PR, then making the algorithm changes in the next.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's okay? Or maybe create one more PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That does now make the "Files Changed" diff much easier to read.
Personally I would re-create or squash and re-push this branch to remove those indentation commits entirely from the git history, but others may have different opinions there. Not sure what the repo's standards are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out @pkamb
RobertoMachorro
commented
Sep 15, 2020
is this pull abandoned or will someone be doing an update on the conflict?
Checklist
Description
Fixed inconsistencies in Boyer-Moore-Horspool string search algorithm
Rewritten hash functions in Rabin-Karp string search algorithm
Simplified code in Knuth-Morris-Pratt String Search algorithm