-
Couldn't load subscription status.
- Fork 5k
Adds binary recursive stein algorithm to the GCD class #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Improves the LCM by passing the used GCD algorithm into the function. * Find an easy GCD function if possible.
* Was intended to be a second example, but is not yet implemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 😄 I love the different implementations for gcd!
I added a couple inline comments. Overall:
- Great job on the different implementations of
gcd. The comments, in particular, are well worded and describe what each algorithm accomplishes. - I think the README needs more details on the different implementations of
gcd. Specifically, I'd leave the beginning of the README the same as it was before and add an advanced section below Least Common Multiple where you can go into detail about the different implementations and why one should prefer one over the other. Thoughts?
- Default parameter values - umbrella for different gcd implementations with generic gcd(_: _:) function - better structure of readme file including all 3 algorithms
@richard-ash Thank you for the valid comments. I updated my pull request according to that. The example code is now moved into the playground's Sources folder and the README is extended with details regarding all three algorithms and a short discussion.
Awesome thanks so much @kayoslab. Changes look 💯
Checklist
Description