-
Couldn't load subscription status.
- Fork 5k
Add AVL tree rotation example image; #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AVL tree rotation example image; #319
Conversation
Update image; Update image;
I think it'll be good to explain the steps in the rotation. For example, how you might find the pivot, how you want to disconnect and reconnect the nodes.
Otherwise, the graph is a solid addition 👍
@kelvinlauKL Thanks for the response, I'm completely agree, I'll update the PR with the steps description 👍
@kelvinlauKL I've added some explanation, could you take a look if this made the image clear or not 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think there are some improvements to make:
-
Split up the diagrams, the first one should show where
pivot,root,rotationalSubtreeandoppositeSubtreeare. -
Put the terminology explanation right after the first diagram.
-
Next, show the 3 steps in rotation the tree, number each diagram.
-
Explain the steps in the rotation using a numbered list to help the reader match each explanation with each diagram.
Great job so far 👍 It's starting to come together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here - "parent not" should be "parent node"
@kelvinlauKL thanks for the valuable feedback, I'll work on improvements 👍
@kelvinlauKL please ignore the commits for now, we can squash them later 😄
Okie dokie, let me know when it's ready.
Okie dokie, let me know when it's ready.
Ah sorry, I meant ignore the commit message and that the message is repeating 😄 but you can take a look on the implementation already 😉
Looks great 👍 👍 👍 Merging it in. Thanks @Antondomashnev, and Merry Christmas!!
@kelvinlauKL merry Christmas ⛄️
I've tried to follow the style of existing images in the AVL tree readme, however it's not 100% the same 😄